Smart Fee Mod for Local Wallet

LithStud

@gpedro good thing you mentioned cancelation ones :) totaly forgot about that one :) and as isaid for money and messages it cant be done currently unless one idea i am thinking about worksout :)

Hect0r

Maybe set a limit on high priority transactions amount, maybe set a limit on amount sent to >= 20 burst per tx, make it more expensive to transact meaning moveing larger amounts around.!

LithStud

@Hect0r i will not impose any limits, this tools sole purpose is to suggest a fee that would make the action a priority in next block - and its up to user to decide if he gonna use it or not :) One way is to just use suggested fee - 1 to be of same priority as majority in previous block. Or just put in whatever fee feels right :) Currently Money transfer works in a way that it increases fee by 1 burst every 10k-20k BURST if i remember correctly (thats one of the reason i cant simply hook my mod and change it).

RichBC

looking good . There are some 501 + 501 Blocks going through with a fee of 3 at the moment if someone wants to test. Just a thought can a fee be 3.1?

Rich

LithStud

@RichBC i had tried fractional fee some time ago, but it seemd to me not working (system took it as 3fee i think)

gpedro

@LithStud If you forget about that one, you probably missed the asset issuing too ;P
Why did you said you can't do it for the money transfers and messages?
I can't find that answer in the previous replys...

How do you calculate the fee? You check the last block fees and divide for the last block number of transactions, then roundup? If so, i can't understand why can't you do it for the transfers and messages... xP

EDIT: just readed the reason for the money transfers xD

daWallet

@RichBC

As you see it is totally worth to support LithStud's development.

gpedro

@LithStud maybe a good solution for apply this to the transfers is:

1 - put a checkbox saying something like "Urgent" in the transfer pop up (next to the fee)
2 - make the wallet check if the checkbox is activated
2.1 - if yes, check if the suggested fee is lower than the automatic filled fee
2.1.1 - IF yes then proceed as usual
2.1.2 - IF no then replace the fee for the suggested fee and do transaction
2.2 - IF no checkbox activated proceed as usual

Problem with this: IDK if you can change the action made with the button send but i am sure you and @dawallet will get a workaround xP

Regarding the messages i don't see why it will not work with the current algo you have right now ;D

LithStud

@gpedro yes thats what i will try to do,basically i will try to take control of the code that does those changes inside wallet (thats assuming i can do that and its not done in such a way that becomes so unfeasable that its not worth the trouble) Not sure why messages cant be autofilled i suspect there is a piece of code that doing similar thing to the one responsible with send money functionality. How i know? I tried to hook the damn things :D

LithStud

@gpedro said in Smart Fee Mod for Local Wallet:

How do you calculate the fee? You check the last block fees and divide for the last block number of transactions, then roundup? If so, i can't understand why can't you do it for the transfers and messages... xP

its not that simple :) its actually determines what the majority fee in that block is and suggests accordingly :) to aproach it in the way of averaging fee per block would be expensive in a sense one transaction with 100 burst would screw everything :D

gpedro

@LithStud said in Smart Fee Mod for Local Wallet:

Not sure why messages cant be autofilled i suspect there is a piece of code that doing similar thing to the one responsible with send money functionality.

Well the message is a money sending transfer in the API, just has the amount set as 0 so probably the issue is related but i am pretty sure you will get it hehe

Will try the mod when i get to the PC with the local wallet ;D

LithStud

Since yesterday was lazing around doing nothing :) today sat down and did some improvements :)
mostly improved the algo decision making to what fee to suggest :) as the current version running on some people wallets might be exploited in some rare cases (and i mean so rare that i am not sure if it can be done on blockchain lol, since i did it with manually made fee array (just array of numbers) and manually arranged it). Anyway back on topic :) the improvement will introduce a minimum fee extraction from last block, so in the case where traffic is normal and blocks get full with transactions the recommended fee will reflect minimum fee in that block (thats assuming algo couldnt find majority fee).

What is majority fee - that is the number that appears as fee more than half of times (tx number / 2), less then that and there is no majority fee thus it could be decided as any fee might get through (as stated before - no time bending algos allowed ;) ).

What am i working at now? Improving design of the mod, so it pleases the eye, also it is part of my ongoing trend throu mods to improve wallets UI visual style by making it look a bit more organic and not so static (so things like the spinner in reward assigment mod).

Also want to thank those who donated last night (night for me might of been day for you) it was really a pleasant surprise when i opened my wallet :D

and now i am going back to code

LithStud

So first off - i am almost done with the mod! :D
Second: the way taking over fee changing around wallet worked so well that well... I changed it everywhere xD
So third i guess i would like to hear from people who uses wallet way more than me where Tx fee was not usual 1 BURST as it would help for me to exclude autochanging fee on those parts only :)

bandarfjb

This is very cool! @LithStud

Ip85

@LithStud Nice donation from Mr.Whale:)

RichBC

@LithStud said in Smart Fee Mod for Local Wallet:

So third i guess i would like to hear from people who uses wallet way more than me where Tx fee was not usual 1 BURST as it would help for me to exclude autochanging fee on those parts only :)

Is this question aimed at all Wallet users, or just people testing the Mod. If the former I would be happy for the Mod to be applied for all transaction types, so long as the fee is visible and there is an opportunity to manually change it down. So in effect the complete opposite of what we have now.

Rich

LithStud

@RichBC thats the thing :) i now pretty much take over any fee input that exists on modals. And that includes new asset fee (1000 BURST) also those in dividends+ that normally are empty (i guess it calculates itself? never used that one).

So i know i need to exclude new asset fee. Not sure about dividends+ ones and also dont know if i am not missing something.

Question aimed at anyone using wallet ;)

And lastly, unless you know that you can press advaced on those pop up windows to set your own fee you might not see it. As in that case it visible in lower left corner only. Not sure if i could make it more visible (i would rather not modify it unnecessary)

RichBC

@LithStud Yes good points and reminds me that there are several fees that I do not use and have not thought about. Dividend payment are a good example where the Asset owner would probably not want the expense.

It does bring up another idea :-) sorry.... That is an option to say I want the dividend payments to be made with a standard fee, but only when the recommended fee would be 1.

LithStud

@RichBC well for dividends i wont be going into them :) what with me making my own version :P so i guess i will just exclude it :D

Also send money retains its functionality to increase fee by itself (so it takes control as soon BURST amount is entered, trying to find where it is done and see if i can somehow disable it)

LithStud

And the mod is live :) please scroll to the first post ;)
OK going to sleep :) any and all questions will be answered in about 4h after i wake up and on my way to work :)