Burstnation & Network situation & Local Wallets
-
holly shit havent tried it so didnt know that, i assumed since there is fee possible to enter it should work, didnt expect it hardcoded o_O
-
@LithStud Yep i did not expect that, too. There is no good reason for this behavior, and i should be not that hard to fix it in next version.
-
i am looking at the java code, so far doesnt seem like its there, looking further
-
src/java/nxt/TransactionType.java line 1767
(omg so much lines code github could not provide deeplinking it ...)if(transaction.getAmountNQT() != 0 || transaction.getFeeNQT() != Constants.ONE_NXT) { throw new NxtException.NotValidException( "Reward recipient assisnment transaction must have 0 send amount and 1 fee: " + transaction.getJSONObject()); }We just need to remove
|| transaction.getFeeNQT() != Constants.ONE_NXTand change the text ^^ it will make the fix and test it.
-
@luxe yeah that the one, why the fuck would anyone hardcode it? O_O
Text should read "Not enough BURST to set new reward recipient" i think that s a descriptive enough
-
@LithStud the pressure on the dev to find a solution to mine on pools with your own plots was quite high. Also there were almost no transactions per block to that time.
-
@daWallet AHH good old :D i will patch it up for now :D gonna fix it later :D
-
Yes bugs/mistakes happen ... gladly we are in the situation that we took over the code and can improve/fix it ... @LithStud it will not help you if it is just fixed in one wallet instance ... other wallets will not confirm that transaction cause they still have the other code i guess. Also i want to check for side effects and stuff ... we will fix this in next version. Maybe together with other related things.
-
@luxe well mod itself still is usefull as it gives easy and understandable way to change recipient, just that fee wont work, also by the time itds done i will allready rewriten code so it is a part of existing wallet and not injected by mod :)
-
Glad to see this kind of exchanges happening here, trying to get things fixed for real. This is what makes Burst great again :)
-
@vExact said in Burstnation & Network situation & Local Wallets:
Glad to see this kind of exchanges happening here, trying to get things fixed for real. This is what makes Burst great again :)
Make it even GREATER!!

